Reviewer: Joseph Touch Review result: Ready with Nits This document defines a YANG model for configuring router QoS parameters. Understandably, it does not provide a single, definitive approach, but instead defines modules that can be supplemented as needed to represent the parameters of specific devices. Although that’s consistent with the YANG model approach, it also seems to somewhat undercut the basic idea of a common model. This is a deficiency in the IETF’s QOS approach, however, rather than being specific to this document. I did not note any areas of concern to INTAREA. >From a YANG viewpoint, I found the sole use of “leafref” (queue policy) a bit concerning; it seems like there ought to be more than just a single case of a named object whose names are referred to elsewhere in ways the YANG model can verify. Almost anything with a name whose name is referenced elsewhere within this model would be a candidate as leafref, e.g. Minor nits: The Traffic-Group definition appears misworded (remove “is a”) and is somewhat incomplete (what kinds of meta data?): * Traffic-Group: is a metadata stored in a packet buffer. There are some parts where the terminology and explanation yield redundant or tautological statements; it would be useful to rephrase these – the first of which is “vendors might want to extend the model to add their own extensions, such as to extend Traffic Policy module”. -- last-call mailing list last-call@xxxxxxxx https://www.ietf.org/mailman/listinfo/last-call
