Hi Martijn,
Thanks for the changes, they address my comments (as implied by my
Approval on your PR just now).
Best,
Reese
On 9/26/23 12:03, Martijn van Beurden wrote:
Hi Reese,
Many thanks for your review, it is very much appreciated. I've tried
to address your comments at
https://github.com/ietf-wg-cellar/flac-specification/pull/232 Would
you consider taking a look at it?
Kind regards, Martijn van Beurden
Op di 26 sep 2023 om 01:00 schreef Reese Enghardt via Datatracker
<noreply@xxxxxxxx>:
Reviewer: Reese Enghardt
Review result: Ready with Nits
I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair. Please treat these comments just
like any other last call comments.
For more information, please see the FAQ at
<https://wiki.ietf.org/en/group/gen/GenArtFAQ>.
Document: draft-ietf-cellar-flac-11
Reviewer: Reese Enghardt
Review Date: 2023-09-25
IETF LC End Date: 2023-09-27
IESG Telechat date: Not scheduled for a telechat
Summary: The document is very well-written and clear. It is ready for
publication, I just found a few nits.
Major issues: None.
Minor issues:
Section 8.8:
When discussing URIs in absolute or relative form, please consider
citing RFC
3986.
Nits/editorial comments:
Section 4.4:
"If indeed most residual samples are close to zero and a suitable Rice
parameter is chosen, this form of coding, a so-called
variable-length code,
fewer less bits to store than storing the residual in unencoded
form." "fewer
less bits" -> "uses fewer bits"?
Section 6:
"If a frame header refers to the streaminfo metadata block, the
file is not
'streamable', see Section 7 for details. In this way, the file is
streamable
and the frame header size small for all of the most common forms
of audio
data." What does "In this way" refer to here? In the second
sentence, "the
file" does not refer to the same file as in the first sentence, or
does it?
Please consider rephrasing this part to make it clearer what is
being said.
--
last-call mailing list
last-call@xxxxxxxx
https://www.ietf.org/mailman/listinfo/last-call
