Many thanks, Shawn. I have the nits fixed in my buffered copy. Cheers, Adrian -----Original Message----- From: Shawn Emery via Datatracker <noreply@xxxxxxxx> Sent: 09 July 2023 06:37 To: secdir@xxxxxxxx Cc: draft-ietf-teas-rfc3272bis.all@xxxxxxxx; last-call@xxxxxxxx; teas@xxxxxxxx Subject: Secdir last call review of draft-ietf-teas-rfc3272bis-24 Reviewer: Shawn Emery Review result: Has Nits This informational track draft provides an up-to-date description of common Internet traffic engineering concepts from the original RFC which was published in 2002. The security considerations section does exit and states that this draft doesn't introduce any new security issues, which I agree. The section discusses the implications of when an attacker does compromise the control and management protocols of TE networks. This could lead to the adversary diverting traffic to nodes controlled by the attacker, in which case the privacy of the transmitted data can be compromised. The traffic could also be sent to the wrong place or slower network in order to perform a DoS of the affected traffic. The document doesn't prescribe mitigating steps for said attacks. I find this appropriate given the intent of this draft, which is to describe a compilation of protocols. General comments: A well written and comprehensive document, however I mainly focused on the changes from RFC 3272 to this draft. Thank you for Appendix A. Editorial comments: s/example operating/example of operating/ s/Exampls/Examples/ s/netrok/network/ s/conforma/conforms/ s/determination of/determined by/ s/is conformed with for/conforms with/ s/enters a/enters/ -- last-call mailing list last-call@xxxxxxxx https://www.ietf.org/mailman/listinfo/last-call