Hi, In Q2_4, I note that the URIs have been replaced by fireeye URIs... Anyway, I assume the reader will know which example in the draft I am referring to :) Regards, Christer -----Original Message----- From: last-call <last-call-bounces@xxxxxxxx> On Behalf Of Christer Holmberg via Datatracker Sent: Tuesday, 16 May 2023 15.37 To: gen-art@xxxxxxxx Cc: draft-ietf-httpapi-link-template.all@xxxxxxxx; httpapi@xxxxxxxx; last-call@xxxxxxxx Subject: [Last-Call] Genart last call review of draft-ietf-httpapi-link-template-02 Reviewer: Christer Holmberg Review result: Ready with Issues I am the assigned Gen-ART reviewer for this draft. The General Area Review Team (Gen-ART) reviews all IETF documents being processed by the IESG for the IETF Chair. Please treat these comments just like any other last call comments. For more information, please see the FAQ at <https://wiki.ietf.org/en/group/gen/GenArtFAQ>. Document: draft-ietf-httpapi-link-template-12 Reviewer: Christer Holmberg Review Date: 2023-05-16 IETF LC End Date: 2023-05-29 IESG Telechat date: Not scheduled for a telechat Summary: The document is well written and easy to read. However, there are some issues and editorial nits that I would like the authors to address. Major issues: Section 2: ========== Q2_1: There is no ABNF for the header field. There are examples using both quotes ("/{username}") and angle brackets (</books/{book_id}/author>), so please include the ABNF. --- Q2_2: The text says "Parameter values MUST be Strings." It is unclear what "Strings" means. Does it mean that parameter values must be encoded as quoted-strings? If so, why? RFC8288 says that parameter values can be encoded both as token and quoted-string. --- Minor issues: N/A Nits/editorial comments: Section 2: ========== Q2_3: The text says: Link-Template: </books/{book_id}/author>; rel="author" anchor="#{book_id}" Is there a ";" missing between the rel and anchor parameters? --- Q2_4: The text says: Link-Template: "/widgets/{widget_id}" rel="https://protect2.fireeye.com/v1/url?k=31323334-501d5122-313273af-454445555731-8682063e6d15ae87&q=1&e=95c5bf1c-a087-4c32-8166-dbfbf8b8d0d8&u=https%3A%2F%2Fexample.org%2Frel%2Fwidget";; var-base="https://protect2.fireeye.com/v1/url?k=31323334-501d5122-313273af-454445555731-1500fdce5a713cb0&q=1&e=95c5bf1c-a087-4c32-8166-dbfbf8b8d0d8&u=https%3A%2F%2Fexample.org%2Fvars%2F"; Is there a ";" missing at the end of the first line? --- -- last-call mailing list last-call@xxxxxxxx https://www.ietf.org/mailman/listinfo/last-call
<<attachment: smime.p7s>>
-- last-call mailing list last-call@xxxxxxxx https://www.ietf.org/mailman/listinfo/last-call
