As chair, thanks for this review, Ralf. I think this is our WG’s first DNS-DIR review, and it is very much appreciated.
Joe
From: Ralf Weber via Datatracker <noreply@xxxxxxxx>
Date: Wednesday, January 11, 2023 at 07:14
To: dnsdir@xxxxxxxx <dnsdir@xxxxxxxx>
Cc: draft-ietf-opsawg-add-encrypted-dns.all@xxxxxxxx <draft-ietf-opsawg-add-encrypted-dns.all@xxxxxxxx>, last-call@xxxxxxxx <last-call@xxxxxxxx>, opsawg@xxxxxxxx <opsawg@xxxxxxxx>
Subject: Dnsdir last call review of draft-ietf-opsawg-add-encrypted-dns-07
Reviewer: Ralf Weber
Review result: Ready with Nits
Moin!
I'm the assigned reviewer of the DNS Directorate for this draft. Given that the
add working group defines drafts for getting encrypted DNS resolver settings to
clients I was initially surprised to see this draft coming from ops area to the
DNS directorate for review.
However looking into while reviewing it is this has become clear as the
attributes defined by add DNR draft are just one user of the specification of
this draft. The draft uses and existing specifications on interactions between
DHCP and Radius and adds DNR as one use case. As such while the draft was
started with, explains this use case and does so fine there is not much for the
DNS directorate to review.
I see this draft as ready with the following nits:
- The table of attributes under 7 Table of attributes only have two values
which both start with 0. As the main distinction is that attributes MUST NOT
appear when 0 is there and MAY appeare when 0+ is defined making this boolean
with e.g Y/N seems easier to understand IMHO. - In 8.1 New Radius Attributes
the table is called "Table 1: Encrypted DNS RADIUS Attributes", while the table
describer generic DHCP Options attributes. The table name should reflect that.
So long
-Ralf
|
--
last-call mailing list
last-call@xxxxxxxx
https://www.ietf.org/mailman/listinfo/last-call
