Elwyn, On Fri, Nov 18, 2022 at 06:37:42AM -0800, Elwyn Davies via Datatracker wrote: > Summary: Ready with nits. There are a number of places where additional > refereences would be helpful and the introduction doesn't say what it is going > to do to solve the identified problem. XXX > Nits/editorial comments: > Abstract: Please include references to the BFD protocol specification [RFC > 5880]. Done. See this, and related updates in the attached diff. > Abstract, para 2: > OLD: > This document defines a Subcode for the BGP Cease NOTIFICATION > message for when a BGP connection is being closed due to a BFD > session going down. > NEW: > This document defines a Subcode for the BGP Cease NOTIFICATION > message [RGC 4271, Section 6.7] for use when a BGP connection is > being closed due to a BFD session going down. > END Done. > S1, para 3: > OLD: > If a BGP speaker desires to have its connections terminate faster > than the negotiated BGP Hold Timer can accommodate upon loss of > connectivity with a neighbor, the BGP speakers can rely upon BFD is > used to supply that faster detection. When the BFD session state > changes to Down, the BGP speaker terminates the connection with a > NOTIFICATION message sent to the neighbor, if possible, and then > close the TCP connection for the connection. > > NEW: > If a BGP speaker desires to have its connections terminate more quickly > than the negotiated BGP Hold Timer can accommodate upon loss of > connectivity with a neighbor, the BFD protocol can be relied upon by BGP > speakers to detect the loss of connectivity more rapidly. When the BFD > session state changes to Down, the BGP speaker terminates the connection > with a Cease NOTIFICATION message sent to the neighbor, if possible, and > may then close the TCP session for the connection. > > This document defines a subcode "BFD Down" to be sent with the Cease > NOTIFICATION message that indicates the reason for this type of connection > termination. > ENDS I've chosen to incorporate portions of your changes. The diff for this change will cover that but is likely to be further altered in the edits suggested by John Scudder. > s3, last para: s/it may not be possible/it may not have been possible/ Changed. > s5: s/Reference of this document/reference to this document/ Changed. > s5: It would be useful to provide a reference to the relevant IANA registry > https://www.iana.org/assignments/bgp-parameters/bgp-parameters.xhtml#bgp-parameters-8 Done. > s7: Arguably I would say RFC 4482 should be a normative reference. I'm presuming you meant 5882 here. I'm fine with that. -- Jeff diff --git a/draft-ietf-idr-bfd-subcode.xml b/draft-ietf-idr-bfd-subcode.xml index ebd5146..7c642e0 100644 --- a/draft-ietf-idr-bfd-subcode.xml +++ b/draft-ietf-idr-bfd-subcode.xml @@ -47,7 +47,7 @@ <!-- <keyword/> --> <abstract> <t> - The Bidirectional Forwarding Detection (BFD) protocol is used to detect + The Bidirectional Forwarding Detection (BFD) protocol [RFC 5880] is used to detect loss of connectivity between two forwarding engines, typically with low latency. BFD is leveraged by routing protocols, including the Border Gateway Protocol (BGP), to bring down routing protocol @@ -55,6 +55,7 @@ </t> <t> This document defines a Subcode for the BGP Cease NOTIFICATION message + <xref target="RFC4271" format="default" sectionFormat="comma" section="6.7"/>, for when a BGP connection is being closed due to a BFD session going down. </t> @@ -89,14 +90,19 @@ three seconds. </t> <t> - If a BGP speaker desires to have its connections terminate faster + If a BGP speaker desires to have its connections terminate more quickly than the negotiated BGP Hold Timer can accommodate upon loss of - connectivity with a neighbor, the BGP speakers can rely upon BFD + connectivity with a neighbor, the BFD protocol can be relied upon by BGP speakers to supply that faster detection. When the BFD session state changes to Down, the BGP speaker terminates the connection with a - NOTIFICATION message sent to the neighbor, if possible, and then closes + Cease NOTIFICATION message sent to the neighbor, if possible, and then closes the TCP connection for the connection. </t> + <t> + This document defines a subcode, "BFD Down", to be sent with the Cease + NOTIFICATION message that indicates the reason for this type of + connection termination. + </t> </section> <section numbered="true" toc="default"> <name>BFD Cease NOTIFICATION Subcode</name> @@ -128,7 +134,7 @@ </t> <t> When there is a total loss of connectivity between two BGP speakers, it - may not be possible for the Cease NOTIFICATION message to have been sent. + may not have been possible for the Cease NOTIFICATION message to have been sent. Even so, BGP speakers SHOULD provide this reason as part of their operational state. Examples include bgpPeerLastError in the BGP MIB <xref target="RFC4273" format="default"/>, and "last-error" in @@ -155,9 +161,13 @@ delete this note to IANA prior to publication. </t> <t> - IANA has assigned the value 10 from the BGP Cease - NOTIFICATION message subcodes registry with the Name "BFD Down", and a - Reference of this document. + IANA has assigned the value 10 from the + <eref target="https://www.iana.org/assignments/bgp-parameters/bgp-parameters.xhtml#bgp-parameters-8";> + BGP Cease NOTIFICATION message subcodes registry + </eref> + with the Name "BFD Down", and a Reference to this document. </t> </section> <section numbered="true" toc="default"> @@ -180,13 +188,13 @@ <xi:include href="https://xml2rfc.ietf.org/public/rfc/bibxml/reference.RFC.2119.xml"/> <xi:include href="https://xml2rfc.ietf.org/public/rfc/bibxml/reference.RFC.4271.xml"/> <xi:include href="https://xml2rfc.ietf.org/public/rfc/bibxml/reference.RFC.5880.xml"/> + <xi:include href="https://xml2rfc.ietf.org/public/rfc/bibxml/reference.RFC.5882.xml"/> <xi:include href="https://xml2rfc.ietf.org/public/rfc/bibxml/reference.RFC.8174.xml"/> <xi:include href="https://xml2rfc.ietf.org/public/rfc/bibxml/reference.RFC.8538.xml"/> </references> <references> <name>Informative References</name> <xi:include href="https://xml2rfc.ietf.org/public/rfc/bibxml/reference.RFC.4273.xml"/> - <xi:include href="https://xml2rfc.ietf.org/public/rfc/bibxml/reference.RFC.5882.xml"/> <xi:include href="https://bib.ietf.org/public/rfc/bibxml3/reference.I-D.ietf-idr-bgp-model.xml"/> </references> </references> -- last-call mailing list last-call@xxxxxxxx https://www.ietf.org/mailman/listinfo/last-call
