Hi Susan, Thanks a lot for your comments. "filter-mode" may be either INCLUDE or EXCLUDE. In INCLUDE mode, reception of packets sent to the specified multicast address is requested *only* from those IP source addresses listed in the source-list parameter. In EXCLUDE mode, reception of packets sent to the given multicast address is requested from all IP source addresses *except* those listed in the source-list parameter [RFC 3376]. Generally there are more than one source-address for a group-address. Some source-addresses are include mode, and others are exclude mode. For example, group-address "233.252.0.23" has two source-addresses, which are 192.0.2.1 and 192.0.3.1. The 192.0.2.1 is include mode, and the 192.0.3.1 is in exclude mode. BR/Hongji -----Original Message----- From: Susan Hares via Datatracker <noreply@xxxxxxxx> Sent: 2022年12月12日 23:09 To: rtg-dir@xxxxxxxx Cc: draft-ietf-pim-igmp-mld-proxy-yang.all@xxxxxxxx; last-call@xxxxxxxx; pim@xxxxxxxx Subject: Rtgdir last call review of draft-ietf-pim-igmp-mld-proxy-yang-08 Reviewer: Susan Hares Review result: Has Issues Revew: Document is readable and matches Yang for 1.1. Status: 1 issue Is it possible that deployments for the filter-mode be require both INCLUDE and EXCLUDE (see pages. 6, 7 and grouping state-group-attribute)? The text says "INCLUDE" or "EXCLUDE". It would be good to know why the authors felt consider the "choice" statement where both "INCLUDE" and "EXCLUDE" would not be possible. Is this due to the normal situation for IGMP-proxy and MLD-Proxy in most deployed? What would happen if both were needed? How can choice be part of an augmentation? Also, this review did not consider the automated tools review. -- last-call mailing list last-call@xxxxxxxx https://www.ietf.org/mailman/listinfo/last-call
