Hi Julian, Thanks for the comments. Please see inline. Cheers, Med > -----Message d'origine----- > De : last-call [mailto:last-call-bounces@xxxxxxxx] De la part de > Julian Lucek > Envoyé : vendredi 6 août 2021 16:06 > À : last-call@xxxxxxxx; opsawg@xxxxxxxx > Objet : [Last-Call] [OPSAWG] Last Call: <draft-ietf-opsawg-l3sm- > l3nm-10.txt> (A Layer 3 VPN Network YANG Model) to Proposed Standard > > I have the following comments: > > 1/ In the BFD section, the ability to invoke a profile should be > moved up a level, i.e. provide a choice between (i) specifying > values for the parameters listed and (ii) invoking a profile > > | +--rw bfd {vpn-common:bfd}? > | +--rw desired-min-tx-interval? uint32 > | +--rw required-min-rx-interval? uint32 > | +--rw detection-multiplier? uint8 > | +--rw (holdtime)? > | | +--:(fixed) > | | | +--rw fixed-value? uint32 > | | +--:(profile) > | | | +--rw profile-name? leafref > [Med] We initially went with this structure to ease the mapping with the L3SM (8299). The assumption is that the profile can include other parameters. I agree this is not clean and it is better to have the profile specified out of this specific parameter. Rather than having a choice between a profile and a set of parameters, I suggest to go with the following: ... | +--rw holdtime? uint32 | +--rw profile? leafref ... With that, a provider can call a profile in addition to a set of customized parameters. Of course, only a profile can be called if needed. > 2/ vpn-network-access is missing the ability to invoke a lag- > interface, including listing which are the member-links. (However > the L2-NM model has this feature, this could be reused in the L3-NM) [Med] We do actually have a discussion as part of the L2NM whether LAG matters (link members, in particular) should be defined independently of the service (and thus removed from the model or at least moved up in the structure). Will need to think further about this one. > > 3/ Example A.1 invokes the vpn-instance-profile at the vpn-network- > access level (as well as the node level). But the vpn-instance- > profile in the example does not contain any parameters that pertain > to a vpn-network-access. In any case, it would be good to have a > revamped example to show how profiles defined or invoked at > different levels interact with or override each other. For example, > a situation in which the route-target is the same across all vpn- > nodes, but each vpn-node has a unique route-distinguisher. Or a > situation in which maximum-routes (among other parameters) is > specified in a profile that is defined at the service level. That > profile is invoked on all of the nodes, but the maximum-routes > parameters is overridden on some nodes, at the node-level or at the > vpn-network-access level. [Med] Sure. Added a simplified example in a new appendix. > > Finally, many thanks to the authors for this very comprehensive and > valuable piece of work. > [Med] Thank you for the various reviews and inputs. > Julian > > -- > last-call mailing list > last-call@xxxxxxxx > https://www.ietf.org/mailman/listinfo/last-call _________________________________________________________________________________________________________________________ Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration, Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci. This message and its attachments may contain confidential or privileged information that may be protected by law; they should not be distributed, used or copied without authorisation. If you have received this email in error, please notify the sender and delete this message and its attachments. As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified. Thank you. -- last-call mailing list last-call@xxxxxxxx https://www.ietf.org/mailman/listinfo/last-call
