Hi Tim, Many thanks for the review and the nits. Updates will be done according to comments added inline. Thanks Bala'zs -----Original Message----- From: Tim Chown via Datatracker <noreply@xxxxxxxx> Sent: Sunday, February 14, 2021 4:34 PM To: int-dir@xxxxxxxx Cc: detnet@xxxxxxxx; draft-ietf-detnet-mpls-over-tsn.all@xxxxxxxx; last-call@xxxxxxxx Subject: Intdir telechat review of draft-ietf-detnet-mpls-over-tsn-05 Reviewer: Tim Chown Review result: Ready with Nits Hi, Re: INT-DIR review of draft-ietf-detnet-mpls-over-tsn-06 This draft details how a DetNet MPLS data plane can run over a TSN sub-network. I have reviewed this document and believe it is Ready for publication, with Nits, as listed below. Nits: p.2 Loss rates -> loss rate Provides congestion -> provide congestion For MPLS-based -> for an MPLS-based <Bala'zs> OK. p.3 Include MSRP and RSVP-TE? <Bala'zs> OK. p.4 And resources -> and resource <Bala'zs> Already fixed in v06. p.5 >From MPLS -> from the MPLS Does not -> do not In case of -> In the case of <Bala'zs> OK. As per the IP doc, not being familiar with DetNet in detail it might be useful to expand on the rationale for mapping to multicast given the “directed” flow. <Bala'zs> OK. See IP doc reply. p.7 As per the IP doc, I note it says there are no requirements stated for TSN-unaware MPLS DetNet nodes in the document, but is it worth adding something about requirements to ensure the TSN Relay can be reached? <Bala'zs> OK. See IP doc reply. p.8 Implementations -> implementation <Bala'zs> OK. P.9 of the document -> of this document challanges -> challenges Are member -=> are members Single hop -> a single hop In some case -> in some cases <Bala'zs> OK. P.10 Regarding the more complicated triggering for TSN-unaware nodes, should further text be added about this? <Bala'zs> I see your point, but that is more a control/management plane issue and not a data plane one. Controller plane discussions recently started in DetNet, so I will keep this comment on the table. :--))) -- Tim -- last-call mailing list last-call@xxxxxxxx https://www.ietf.org/mailman/listinfo/last-call
