On Fri, Apr 17, 2020 at 11:15 PM Lars <larsh@xxxxxxxxxx> wrote: > > This patch allows controlling multiple fans as if they were a single fan. > > This adds P52, P72, X1E, and X1E gen2 to dual fan quirks. Both fans are controlled together. > > Tested on an X1 Extreme Gen2. > > The patch is defensive, it adds only specific supported machines, and falls back to the old behavior if both fans cannot be controlled. > However, it does attempt single fan control for all previously white-listed Thinkpads. > > Background: > I tested the BIOS default behavior on my X1E gen2 and both fans are always changed together. > So rather than adding controls for each fan, this controls both fans together as the BIOS would do. > > This was inspired by a discussion on dual fan support for the thinkfan tool (https://github.com/vmatare/thinkfan/issues/58). > (Thanks to Github users voidworker, and civic9.) > > The BIOS ids for P52/P72 and X1E are taken from there. The X1E gen2 id is verified on my machine. > Thanks for an update. I have pushed it to my review and testing queue, thanks! JFYI: there are two issues (I have fixed them, no need to resend) with this. Commit message lines are too long and... > (In the first version my mail client botched the white-spacing - my apologies, this is my first Kernel patch. Used git send-email and gmail this time.) ...this kind of comments should go after cut line ('---' below). > Signed-off-by: Lars <larsh@xxxxxxxxxx> > --- -- With Best Regards, Andy Shevchenko _______________________________________________ ibm-acpi-devel mailing list ibm-acpi-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
