On Sat, Dec 30, 2017 at 1:49 AM, Ognjen Galić <smclt30p@xxxxxxxxx> wrote: > On Čet, 2017-12-28 at 10:19 +0200, Andy Shevchenko wrote: >> On Sat, Dec 23, 2017 at 12:53 PM, Ognjen Galic <smclt30p@xxxxxxxxx> >> wrote: >> > >> > This patch adds the to_power_supply macro to upcast >> > a device to a power_supply struct. >> > >> > This is needed because the same piece of code using >> > container_of is used in various other places, so we >> > abstract away such low-level operations via a macro. >> > >> > --- >> This is wrong! You have to use *existing* --- line below. Otherwise >> all mail parsers will cut this out including your SoB tag. >> > > My bad I guess. Want another patch revision with that fixed or > something? > You definitely need to send a new revision with all comments addressed. So far you didn't responce to them which I recognize as total agreement that they have to be addressed. -- With Best Regards, Andy Shevchenko ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ ibm-acpi-devel mailing list ibm-acpi-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
