On Tue, 2017-05-09 at 14:10 -0300, Henrique de Moraes Holschuh wrote:
Thanks for review, my comments below.
> On Tue, 09 May 2017, Andy Shevchenko wrote:
> > There is no point to keep string literal split. It even makes
> > slightly
> > harder to maintain and debug.
>
> Ooold code, from a time when random people would annoy others over
> 80-column instead of doing useful reviews...
Yes, I know, nowadays checkpatch doesn't complain on them.
> > While here, print negative error without changing a sign as it is a
> > common pattern in the kernel.
>
> A separate patch for this would be better: it would be easier to
> actually check that no functional changes crept in by mistake.
It doesn't make sense to me. It would touch same lines of code I do
already here and it's only one place, see below.
> > rc = fan_set_enable();
> > if (rc < 0) {
> > - pr_err("fan watchdog: error %d while enabling fan,
> > "
> > - "will try again later...\n", -rc);
> > + pr_err("fan watchdog: error %d while enabling fan,
> > will try again later...\n",
> > + rc);
--
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
ibm-acpi-devel mailing list
ibm-acpi-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
