Hi,
On Tue, Feb 07, 2017 at 11:01:32PM -0200, Henrique de Moraes Holschuh wrote:
> Hello Adam,
>
> I apologise for the delay on answering you.
>
> On Tue, 31 Jan 2017, Adam Goode wrote:
> > On Thu, Jan 19, 2017 at 12:21 PM, Adam Goode <agoode@xxxxxxxxxx> wrote:
> > > This allows the control of the red status LED, which is the dot of the "i"
> > > in the word "ThinkPad" on the outside cover of newer models.
> > >
> > > In the manual, both this LED and the power LED are referred to as
> > > the "system-status indicators" without distinction between the two, so
> > > I chose "status" as the LED name.
>
> I seem to recall this LED had an ACPI interface that was specific for
> it, and allowed it to on/off/sine-wave?
I don't know what the ACPI interface looks like, but the lid status
led goes into sine-wave mode during suspend. Note, that the power-led
also goes into sine-wave mode during suspend and is already supported
by thinkpad-acpi's LED code (without the sine-wave feature as far
as I can tell).
> > > Signed-off-by: Adam Goode <agoode@xxxxxxxxxx>
> > >
> > > diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/
> > > thinkpad_acpi.c
> > > index cacb43fb1df7..6577bf8e5635 100644
> > > --- a/drivers/platform/x86/thinkpad_acpi.c
> > > +++ b/drivers/platform/x86/thinkpad_acpi.c
> > > @@ -5611,11 +5611,11 @@ static const char * const
> > > tpacpi_led_names[TPACPI_LED_NUMLEDS] = {
> > > "tpacpi::standby",
> > > "tpacpi::dock_status1",
> > > "tpacpi::dock_status2",
> > > - "tpacpi::unknown_led2",
> > > + "tpacpi::status",
"status" looks a bit generic. I suggest "external_lid_status".
> > > "tpacpi::unknown_led3",
> > > "tpacpi::thinkvantage",
> > > };
> > > -#define TPACPI_SAFE_LEDS 0x1081U
> > > +#define TPACPI_SAFE_LEDS 0x1481U
>
> What happens on older Lenovo models (x00, x10, x20 series?)? I think
> the T410 already had it...
>
> Also, please add code to not export it to userspace (as a led class) on
> IBM.
Adam, can you prepare an updated patch? I would like to use this
led to notify myself about events (i.e. compilation finished)
while my thinkpad's lid is closed.
-- Sebastian
Attachment:
signature.asc
Description: PGP signature
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________ ibm-acpi-devel mailing list ibm-acpi-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
