Re: [PATCH v4 3/4] platform: x86: dell-*: Add a generic dell-laptop notifier chain

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On 11-11-16 15:17, Pali Rohár wrote:
> On Tuesday 01 November 2016 14:37:47 Hans de Goede wrote:
>> @@ -43,4 +45,13 @@ void dell_smbios_release_buffer(void);
>>  void dell_smbios_send_request(int class, int select);
>>
>>  struct calling_interface_token *dell_smbios_find_token(int tokenid);
>> +
>> +enum dell_laptop_notifier_actions {
>> +	dell_laptop_kbd_backlight_brightness_changed,
>> +};
>
> Should not be upper case? Looks like that Documentation/CodingStyle also
> suggest it:
>
> Names of macros defining constants and labels in enums are capitalized.

Ok, I will send a v5 once we agree on how to do the thinkpad bits.

Regards,

Hans


------------------------------------------------------------------------------
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today. http://sdm.link/xeonphi
_______________________________________________
ibm-acpi-devel mailing list
ibm-acpi-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel




[Index of Archives]     [Linux ACPI]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Photo]     [Yosemite Photos]     [Yosemite Advice]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]

  Powered by Linux