(Sorry, I just subscribed to the list and I can't set a reply-to here.)
Hi Lyude,
I'm working on the same for a Yoga 260.
Your patch works fine with one addition, the event number is 0x60f0 here.
And when flipping the display for the first time I see one 0x60c0
before the 0x60f0. Just once, 0x60c0 doesn't show up after that
anymore.
One remark to your patch. In hotkey_init(), case
TP_HKEY_EV_TABLET_CHANGED you don't call
hotkey_tablet_mode_notify_change() and don't set send_acpi_ev=false as
it's done on TP_HKEY_EV_TABLET_{TABLET,NOTEBOOK}. Shouldn't those
cases be equally handled?
I don't know how likely it is that the next hardware version will use
yet another method for querying. Though, I would like to refactor the
code to be prepared for such a case. Bad idea? I would:
- move hotkey_tablet detection into a new hotkey_init_tablet_mode(),
- use an enum for tp_features.hotkey_tablet, then
- add your X1 Yoga changes modified on top and finally
- add the Yoga 260.
Cheers,
Daniel
------------------------------------------------------------------------------
The Command Line: Reinvented for Modern Developers
Did the resurgence of CLI tooling catch you by surprise?
Reconnect with the command line and become more productive.
Learn the new .NET and ASP.NET CLI. Get your free copy!
http://sdm.link/telerik
_______________________________________________
ibm-acpi-devel mailing list
ibm-acpi-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
