Il 14/05/2016 22:16, Henrique de Moraes Holschuh ha scritto: > On Fri, 13 May 2016, Marco Trevisan wrote: >> The current implementation of the keyboard backlight driver uses the >> default led suspend/resume implementation, which causes the driver not >> to restore the kbd backlight on resume. >> >> The attached patch fixes this. > > I am fine with it, although I wonder why the LED class is not doing what it > is supposed to, since... > >> - .flags = LED_CORE_SUSPENDRESUME, > > It was asked to handle suspend/resume. Whatever. The reason why it doesn't work, is that it would assume that the driver updates the led class brightness field once this value changes, and thus it will set it back to the proper value on resume. Unfortunately this is not something we could do since I don't think we're getting any ACPI event when the kbd backlight changes. At least, I've not been able to track it, but if there's a known way to monitor this change, other than polling the EC, I could improve the things. So, any suggestion is welcome... I'm very new new to these things, but I like to learn. > Anyway, > Acked-by: Henrique de Moraes Holschuh <hmh@xxxxxxxxxx> > > Please send it to the platform-driver-x86 ML with my acked-by, ensure you cc > both me and the subsystem maintainer. Thanks! Ok, thanks. ------------------------------------------------------------------------------ Mobile security can be enabling, not merely restricting. Employees who bring their own devices (BYOD) to work are irked by the imposition of MDM restrictions. Mobile Device Manager Plus allows you to control only the apps on BYO-devices by containerizing them, leaving personal data untouched! https://ad.doubleclick.net/ddm/clk/304595813;131938128;j _______________________________________________ ibm-acpi-devel mailing list ibm-acpi-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
