On Sat, 09 Apr 2016, Matthias Hochsteger wrote: > This way I managed to control both fans individually. As I mentioned, > this code is just a hack and what's totally missing is some detection of > the second fan. I would appreciate some help there. Two-fan thinkpads are rare enough that we can use a quirk list for now. This thing needs to be whitelist-based anyway, as it is a direct-write-to-EC feature, so we can only enable it by default on tested models. >From your patch, I understand the select_fan() thing we already have for the X60/X61 actually changes which fan is being controlled on the P50? I wonder if it actually worked that way on the X60/X61... I don't recall if we tested that at the time. Is anyone with a X60 or X61 around that could test it? Otherwise, we can simply add a new quirk for second-fan-control-ok, and enable second-fan control only for the P50, and not for the X60/X61. > PS: The P50 also has HKEY version 0x200. I could do some testing there if > needed. Now we just need someone with the original adaptive keyboard (I understand the P50 doesn't have it) to help, but let's keep HKEY 0x200-related stuff on its own thread. -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh ------------------------------------------------------------------------------ Find and fix application performance issues faster with Applications Manager Applications Manager provides deep performance insights into multiple tiers of your business applications. It resolves application problems quickly and reduces your MTTR. Get your free trial! http://pubads.g.doubleclick.net/ gampad/clk?id=1444514301&iu=/ca-pub-7940484522588532 _______________________________________________ ibm-acpi-devel mailing list ibm-acpi-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
