On Thu, Jan 21, 2016, at 09:18, Eric Curtin wrote:
> On 16 January 2016 at 23:43, Eric Curtin <ericcurtin17@xxxxxxxxx> wrote:
> > Message gets logged on machines that are well supported.
> > Fixed one checkpatch.pl ERROR also.
> >
> > Signed-off-by: Eric Curtin <ericcurtin17@xxxxxxxxx>
> > ---
> > drivers/platform/x86/thinkpad_acpi.c | 6 ++----
> > 1 file changed, 2 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/platform/x86/thinkpad_acpi.c
> > b/drivers/platform/x86/thinkpad_acpi.c
> > index 0bed473..b149dec 100644
> > --- a/drivers/platform/x86/thinkpad_acpi.c
> > +++ b/drivers/platform/x86/thinkpad_acpi.c
> > @@ -6434,7 +6434,7 @@ static const struct tpacpi_quirk
> > brightness_quirk_table[] __initconst = {
> > */
> > static void __init tpacpi_detect_brightness_capabilities(void)
> > {
> > - unsigned int b;
> > + const unsigned int b = tpacpi_check_std_acpi_brightness_support();
This unrelated change can have side-effects, and I didn't stop to look
at the code yet to know if it is desired. Regardless, it should be in a
separate patch anyway as it has nothing to do with the removal of the
log message, so please drop it.
--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh
------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140
_______________________________________________
ibm-acpi-devel mailing list
ibm-acpi-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
