On Mon, Feb 23, 2015 at 2:09 AM, Bastien Nocera <hadess@xxxxxxxxxx> wrote: > On Fri, 2015-02-20 at 11:27 -0800, Andy Lutomirski wrote: >> On 02/20/2015 06:44 AM, Bastien Nocera wrote: >> > + KEY_MICCANCEL_MODE, /* Microphone cancellation */ >> >> What's this? We already have KEY_MICMUTE. Is this different? If so, >> can you improve the comment a bit? > > I don't think the comment needs improving. This is the device driver > part of the patch series. If comment was required, it would in the > commit adding the keycode to input.h. We're discussing that with Dmitry. > Right, sorry, I replied to the wrong patch. >> The answer may be obvious to anyone who has an awful X1 carbon gen 2 >> keyboard, but these KEY_XYZ defines should IMO be clear enough that even >> people without the hardware can figure out what's going on. > > I'll make sure to link this in the input.h patch: > http://www.lenovo.com/shop/americas/content/user_guides/x1carbon_2_ug_en.pdf > > In any case, it doesn't look like this particular keycode will make it. > Oh, it's microphone *noise* cancellation. I assumed it somehow cancelled the microphone, and I was a bit confused. If the keycode ends up getting added, could you add the word "noise" somewhere? Thanks, Andy ------------------------------------------------------------------------------ Dive into the World of Parallel Programming The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net/ _______________________________________________ ibm-acpi-devel mailing list ibm-acpi-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
