On Fri, 2015-02-20 at 19:54 +0100, Bastien Nocera wrote:
> Hey Dmitry,
>
> On Fri, 2015-02-20 at 10:40 -0800, Dmitry Torokhov wrote:
> > On Fri, Feb 20, 2015 at 10:04:04AM -0500, Benjamin Tissoires wrote:
> > > On Fri, Feb 20, 2015 at 9:44 AM, Bastien Nocera <hadess@xxxxxxxxxx> wrote:
> > > > Signed-off-by: Bastien Nocera <hadess@xxxxxxxxxx>
> > > > ---
> > > > include/uapi/linux/input.h | 10 ++++++++++
> > > > 1 file changed, 10 insertions(+)
> > > >
> > > > diff --git a/include/uapi/linux/input.h b/include/uapi/linux/input.h
> > > > index b0a8130..affe40e 100644
> > > > --- a/include/uapi/linux/input.h
> > > > +++ b/include/uapi/linux/input.h
> > > > @@ -740,6 +740,16 @@ struct input_keymap_entry {
> > > > #define KEY_BRIGHTNESS_MIN 0x250 /* Set Brightness to Minimum */
> > > > #define KEY_BRIGHTNESS_MAX 0x251 /* Set Brightness to Maximum */
> > > >
> > > > +#define KEY_CLIPPING_TOOL 0x252 /* Screenshot clipping tool */
> >
> > Do we have users for this?
>
> Bearing in mind that most of those keys won't be usable in X11, but
> should be in Wayland, it might take a little while to actually get used,
> but I would add support for this "clipping tool" key in GNOME. Most
> likely to start a screenshoting tool in selection mode.
>
> > > > +#define KEY_CLOUD 0x253 /* Cloud Settings */
> >
> > Just no. What is cloud settings? Use KEY_VENDOR if you must for this vendor
> > "added value" junk they come up on keyboards year after year. It used to be
> > WWW, not cloud, I bet in 2016 someone will come up with "IoT"-dedicated key.
>
> The button actually looks like a Cloud, see page 46 of this guide:
> http://www.lenovo.com/shop/americas/content/user_guides/x1carbon_2_ug_en.pdf
>
> In GNOME, I would make this start the "Online Accounts" configuration.
> I'm fine with renaming it, but I would prefer something more precise
> than KEY_VENDOR. KEY_WWW would be fine by me.
>
> > > > +#define KEY_CAMERA_GESTURES 0x254 /* Toggle Camera gestures */
>
> This wouldn't get used directly in GNOME.
>
> > > > +#define KEY_NEW_TAB 0x255 /* Open a new tab */
>
> This would get used.
>
> > > > +#define KEY_MICUP 0x256 /* Microphone Up */
> > > > +#define KEY_MICDOWN 0x257 /* Microphone Down */
>
> Those would get used as well.
>
> > > > +#define KEY_MICCANCEL_MODE 0x258 /* Toggle Microphone cancellation mode */
> > > > +#define KEY_CAMERA_ZOOM_MODE 0x259 /* Toggle camera zoom mode */
>
> These 2 wouldn't get used directly in GNOME.
>
> > > > +#define KEY_ROTATE_DISPLAY 0x25a /* Rotate screen by 90 degrees */
> > > > +
> > >
> > > This one should be acked by Dmitry (in CC)
> > >
> >
> > Some of these (like microphone volume up/down) are generic and reasonable, but
> > I need to know if there will be any users for these newly defined keys.
>
> Answers to this in-line above. I'm fine with replacing the keycodes for
> those keys with something that more or less corresponds to the
> pictograms, especially the "Toggle voice-recognition" and "Toggle
> camera-gestures function" are present in all the keyboard modes.
Any more ideas about which keycodes I should add and which ones I should
replace?
------------------------------------------------------------------------------
Dive into the World of Parallel Programming The Go Parallel Website, sponsored
by Intel and developed in partnership with Slashdot Media, is your hub for all
things parallel software development, from weekly thought leadership blogs to
news, videos, case studies, tutorials and more. Take a look and join the
conversation now. http://goparallel.sourceforge.net/
_______________________________________________
ibm-acpi-devel mailing list
ibm-acpi-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
