On Fri, Feb 20, 2015, at 02:28, Darren Hart wrote: > On Wed, Feb 18, 2015 at 09:53:44PM +0100, Bastien Nocera wrote: > > Commit message please. > > > Signed-off-by: Bastien Nocera <hadess@xxxxxxxxxx> > > --- > > drivers/platform/x86/thinkpad_acpi.c | 71 +++++++++++++++++++++++++++++++----- > > 1 file changed, 62 insertions(+), 9 deletions(-) > > > > diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c > > index a6dd017..562d958 100644 > > --- a/drivers/platform/x86/thinkpad_acpi.c > > +++ b/drivers/platform/x86/thinkpad_acpi.c > > ... > > > +static struct device_attribute dev_attr_adaptive_kbd_mode = > > + __ATTR(adaptive_kbd_mode, S_IWUSR | S_IRUGO, > > + adaptive_kbd_mode_show, adaptive_kbd_mode_store); > > + > > Please use DEVICE_ATTR_RW() macros for new sysfs files. > > I'd very much like to see a cleanup of the driver to use these as well. > > Henrique, your thoughts / preference? Converting to DEVICE_ATTR_RW/RO would be welcome. -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh ------------------------------------------------------------------------------ Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server from Actuate! Instantly Supercharge Your Business Reports and Dashboards with Interactivity, Sharing, Native Excel Exports, App Integration & more Get technology previously reserved for billion-dollar corporations, FREE http://pubads.g.doubleclick.net/gampad/clk?id=190641631&iu=/4140/ostg.clktrk _______________________________________________ ibm-acpi-devel mailing list ibm-acpi-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
