On Mon, 2015-02-23 at 07:49 -0300, Henrique de Moraes Holschuh wrote: > On Mon, Feb 23, 2015, at 07:15, Bastien Nocera wrote: > > On Wed, 2015-02-18 at 21:34 -0200, Henrique de Moraes Holschuh wrote: > > > On Wed, 18 Feb 2015, Bastien Nocera wrote: > > > > Signed-off-by: Bastien Nocera <hadess@xxxxxxxxxx> > > > > > > This one requires an ACK from the input maintainers, or no go... > > > > Any comments about the other patches? > > The series looks mostly good, but the new keymap and attributes need to > go > in the driver documentation (Documentation/laptops/thinkpad-acpi.txt), > and some > of the commit decriptions could use an update. > > You could opt to change some of those keypresses dinamically into > driver-specific > ACPI events, by setting the keymap entry to KEY_RESERVED. The driver > will > issue HKEY events in that case. That will be an viable alternative for > some of the new > keys. I don't understand what you mean here. > The beauty of it is that keymaps are configurable in run-time, so > userspace can > just set any key entries it wants to change to something else, and ACPI > events will be > suppressed if the entry is not set to KEY_RESERVED anymore. Keymaps are already configurable at run-time, that's how udev changes keymaps. Or did you mean something else? > We need to be careful with tpacpi_input_send_key_masked(). If any of the > codepaths > could call it from the adaptative keyboard handling code, But we're not calling it from there, are we? > it needs to be > updated (just > assume anything above 32 is enabled, as the firmware does not have an > event mask > for the new keycodes). ------------------------------------------------------------------------------ Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server from Actuate! Instantly Supercharge Your Business Reports and Dashboards with Interactivity, Sharing, Native Excel Exports, App Integration & more Get technology previously reserved for billion-dollar corporations, FREE http://pubads.g.doubleclick.net/gampad/clk?id=190641631&iu=/4140/ostg.clktrk _______________________________________________ ibm-acpi-devel mailing list ibm-acpi-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
