On Mon, 2015-02-23 at 07:25 -0300, Henrique de Moraes Holschuh wrote: > On Fri, Feb 20, 2015, at 11:44, Bastien Nocera wrote: > > Use the DEVICE_ATTR_RW macro to reduce boiler plate > > So far, so good, but you also used the DEVICE_ATTR_RO macro... > > > and move the attribute declaration to get rid of function signatures. > > I didn't see any "move the attribute declaration" done in this patch. Too much cut'n'paste from another similar patch. I'll resend with a better commit message. > Other than that, looks good. Great, thanks. ------------------------------------------------------------------------------ Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server from Actuate! Instantly Supercharge Your Business Reports and Dashboards with Interactivity, Sharing, Native Excel Exports, App Integration & more Get technology previously reserved for billion-dollar corporations, FREE http://pubads.g.doubleclick.net/gampad/clk?id=190641631&iu=/4140/ostg.clktrk _______________________________________________ ibm-acpi-devel mailing list ibm-acpi-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
