On Tue, Apr 1, 2014 at 1:49 AM, Henrique de Moraes Holschuh <hmh@xxxxxxxxxx> wrote:
On Tue, Mar 11, 2014, at 8:01, Shuduo Sang wrote:I am unable to do a full review right now, but we can always adjust
> Resend patch V4. Support Thinkpad X1 Carbon 2nd generation's adaptive
> keyboard.
>
> Hi Henrique, could you please have a chance to review it?
minor details of the feature with later patches and the previous reviews
did help clean up the feature.
However: as far as I am concerned, this is an experimental feature until
it matures for a while. I'd rather we plug this somehow to the
thinkpad-acpi input map, for example.
Yes, I tried to use input map but worry old logic need change many since the new event number
is far to old. The functionality is verified well and get official recognised by Lenovo.
Acked-by: Henrique de Moraes Holschuh <hmh@xxxxxxxxxx>
There are two more patches for X1 carbon adaptive keyboard need review.
[PATCH] save and restore adaptive keyboard mode for suspend and, resume
[PATCH] support thinkpad HKEY interface version 0x200
They are verified by me and other X1 carbon users.
Thanks Henrique.
--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh
------------------------------------------------------------------------------
_______________________________________________ ibm-acpi-devel mailing list ibm-acpi-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
