On Wed, 18 Dec 2013, Lv Zheng wrote: > CONFIG_ACPI dependent code should include <linux/acpi.h> instead of > directly including <acpi/acpi.h>. This patch cleans up such wrong > inclusions for Thinkpad ACPI users. ... > drivers/platform/x86/thinkpad_acpi.c | 1 - > include/linux/thinkpad_acpi.h | 2 ++ > sound/pci/hda/patch_conexant.c | 1 - > sound/pci/hda/patch_realtek.c | 1 - I'd prefer if you left the include outside of thinkpad_acpi.h, and just fix the include in the two ALSA users. We might add some extra stuff to thinkpad_acpi.h someday, and not everything thinkpad_acpi does that might be useful to export to other areas of the kernel would require acpi.h. Looking at patch_conexant and patch_realtek, it might be better to actually move the "am I running on a thinkpad" stuff they use acpi.h for into thinkpad_acpi, and provide a prototype for that in thinkpad_acpi.h. -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh ------------------------------------------------------------------------------ Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk _______________________________________________ ibm-acpi-devel mailing list ibm-acpi-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
