On Fri, 18 Oct 2013, Felipe Pena wrote: > In the thermal_init function when checking for thinkpad_id.ec_model, > the 'ta2' variable is being OR'd when acpi_ec_read call succeeds, > on fail it is setting 0 to 'ta1' variable instead. > > Signed-off-by: Felipe Pena <felipensp@xxxxxxxxx> NAK. ta1 == 0 implies malfunction on the direct-from-EC temperature reading, which is what the code wants to signal. The code is correct as is. Do not merge this patch. -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh ------------------------------------------------------------------------------ October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register > http://pubads.g.doubleclick.net/gampad/clk?id=60135991&iu=/4140/ostg.clktrk _______________________________________________ ibm-acpi-devel mailing list ibm-acpi-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
