Re: thinkpad_acpi: Saving bluetooth state to NVRAM problem and fix

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 10 Jun 2012, Vsevolod Kozlov wrote:
> thinkpad_acpi normally fails to save Bluetooth state to NVRAM on my system
> (ThinkPad X120e).  However, a small change in the code fixes the functionality:
> 
> --- a/drivers/platform/x86/thinkpad_acpi.c
> +++ b/drivers/platform/x86/thinkpad_acpi.c
> @@ -3999,7 +3999,7 @@ static const struct tpacpi_rfk_ops bluetooth_tprfk_ops = {
>  static void bluetooth_shutdown(void)
>  {
>  	/* Order firmware to save current state to NVRAM */
> -	if (!acpi_evalf(NULL, NULL, "\\BLTH", "vd",
> +	if (!acpi_evalf(NULL, NULL, "\\_SB.BLTH", "vd",
>  			TP_ACPI_BLTH_SAVE_STATE))
>  		pr_notice("failed to save bluetooth state to NVRAM\n");
>  	else
> 
> I can't tell whether this breaks the functionality on other ThinkPad systems
> because I don't have any, though.

Yes, it would break other systems.  But I can write a fix that supports both
systems with the data you supplied.

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
ibm-acpi-devel mailing list
ibm-acpi-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel


[Index of Archives]     [Linux ACPI]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Photo]     [Yosemite Photos]     [Yosemite Advice]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]

  Powered by Linux