Re: [PATCH v3] thinkpad-acpi: Improve hardware volume controls

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, May 14, 2011 at 11:34:25AM -0400, Andy Lutomirski wrote:

> It turns out that we can ask ACPI for one of three behaviors
> directly.  They are "latch" (the default), "none" (no automatic
> control), and "toggle" (mute unmutes when muted).  So we let the
> user control the mode through sysfs, and we don't generate KEY_MUTE
> in any mode other than "none".
> 
> As an added bonus, we fix an old bug: the hardware mute control
> doesn't generate an ALSA change notification on newer ThinkPads.

Which of these modes make sense for userspace? "none" sounds like it'd 
be fine, except that the LED wouldn't work on new machines. So should we 
just be setting "toggle" in all cases? The optimal situation would be 
that we delete the OSI blacklist at the same time as we add this code.

-- 
Matthew Garrett | mjg59@xxxxxxxxxxxxx

------------------------------------------------------------------------------
Achieve unprecedented app performance and reliability
What every C/C++ and Fortran developer should know.
Learn how Intel has extended the reach of its next-generation tools
to help boost performance applications - inlcuding clusters.
http://p.sf.net/sfu/intel-dev2devmay
_______________________________________________
ibm-acpi-devel mailing list
ibm-acpi-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel


[Index of Archives]     [Linux ACPI]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Photo]     [Yosemite Photos]     [Yosemite Advice]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]

  Powered by Linux