I've figured out how the ThinkPad SMAPI charge control works (at least well enough to program thresholds on some models), and I'd like to get this functionality into mainline. (This is inspired by, and borrows magic numbers from, tp_smapi, but it has no code at all from tp_smapi and therefore shouldn't have the lack-of-authorship issue.) My question is: what's the best way to expose this functionality? Currently, I have a little driver (not yet in mergeable shape) that creates a platform device and sticks some sysfs attributes in it depending on which thresholds it can figure out how to program. It's here: https://gitorious.org/linux-test-utils/tp_charge/blobs/master/kmod/tp_charge.c I'd like to find a better way, though. Some quick Googling suggests that some Vaio laptops can do this, but I'm afraid that all my laptops are ThinkPads. Two ideas: 1. Integrate this with thinkpad_acpi and keep exposing it as a thinkpad-specific thing (device? new class_device?) in sysfs. 2. Integrate it with power_supply. I like option 2 better, since it means that a userspace tool (like GNOME) could learn how to operate a battery charge controller once and then other laptops and devices could reuse the same interface. The problem is that the ACPI battery driver can't see the charge control. So either it would need a hook to allow per-vendor control like this or the power_supply class would need to recognize separate charge controllers. I have no intention of creating a kitchen sink like tp_smapi. But I might want to add things like forced discharge or outright disabling of charging. On possible added complication: on ThinkPads, the charge thresholds stay in effect until reprogrammed or until the battery is removed, even if the computer is off. Any thoughts? I've never touched the driver model before. --Andy ------------------------------------------------------------------------------ WhatsUp Gold - Download Free Network Management Software The most intuitive, comprehensive, and cost-effective network management toolset available today. Delivers lowest initial acquisition cost and overall TCO of any competing solution. http://p.sf.net/sfu/whatsupgold-sd _______________________________________________ ibm-acpi-devel mailing list ibm-acpi-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
