Re: [Patch] thinkpad_acpi: fix a build error

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



At Fri, 18 Dec 2009 13:03:24 -0200,
Henrique de Moraes Holschuh wrote:
> 
> On Fri, 18 Dec 2009, Takashi Iwai wrote:
> > At Fri, 18 Dec 2009 12:28:15 -0200,
> > Henrique de Moraes Holschuh wrote:
> > > On Fri, 18 Dec 2009, Takashi Iwai wrote:
> > > > The patch isn't correct (I guess the upstream fix is same?).
> > > > 
> > > > CONFIG_SOUND is a global config for sound subsystem.  The relevant
> > > > functions are ALSA core part, which is CONFIG_SND.
> > > > So, the fix should be:
> > > > 
> > > > 	depends on SND
> > > > 
> > > > instead.
> > > 
> > > Indeed.  Ingo already fixed that too.
> > > 
> > > Although I personally would prefer:
> > > select SOUND
> > > select SND
> > 
> > SND already depends on SOUND, so it's just superfluous.
> 
> No, it is not (test it).  Which is the main reason why select can be a pain.

Ah, OK, it's "select".  Yeah it's a real pain, and should be avoided
in such a case...


Takashi

------------------------------------------------------------------------------
This SF.Net email is sponsored by the Verizon Developer Community
Take advantage of Verizon's best-in-class app development support
A streamlined, 14 day to market process makes app distribution fast and easy
Join now and get one step closer to millions of Verizon customers
http://p.sf.net/sfu/verizon-dev2dev 
_______________________________________________
ibm-acpi-devel mailing list
ibm-acpi-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel

[Index of Archives]     [Linux ACPI]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Photo]     [Yosemite Photos]     [Yosemite Advice]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]

  Powered by Linux