Len, Given that there are four cleanup patches in the batch, I didn't even attempt to bother with checkpatch on anything before the "some checkpatch fluff" patch. There are, for example, no tab/space problems in the final thinkpad_acpi.c file. After the entire patchset is applied, there are still a few lines over 80 chars, but that's because they are MUCH more readable the way they are in that particular hunk of code. The braces checkpatch will complain about in the final thinkpad_acpi.c file are there for good reasons. They are in points of the code where I expect a maintenance addition of one or two lines could happen, and that means any such patches would be a lot cleaner. That warning is just weird, anyway. There will be also an error about a macro needing do - while. Well, that one *does not* need it, and it is never used as a function. So, please apply the entire set and check the final thinkpad_acpi.c file with checkpatch --file... It is in *much* better state than what you got with that checkpatch run: 1 error and 12 warnings, which are all explained above. Patches after the cleanups are checkpatch-clean (except for the details explained above). -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ ibm-acpi-devel mailing list ibm-acpi-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
