Re: [PATCH 01/15] ACPI: thinkpad-acpi: refactor hotkey_get and hotkey_set

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 15 Nov 2007, Len Brown wrote:
> > This patch:
> 
> a nit to prove that I read this before dumping it into my test branch...

Hey, I never doubted you read all my patchsets :-)

> the "perfect patch" never refers to itself as a patch
> in its check-in comments -- since by the time it is checked
> in, it is sort of self-evident it is a patch:-)

I will remember that one :-)

> but, Henrique, we're waxing about perfection here -- your
> patch hygene is already some of the best on the list.

I will take that as "applied" ;-)  Thanks!

I now have to decide whether I should follow my heart (indent levels with
tabs, everything else with spaces), or just decide that the kernel
hopelessly chained to tabs-as-8-spaces-only land and pipe thinkpad-acpi
entirely through unexpand to get rid of a huge ammount of checkpatch.pl
nagging...

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
ibm-acpi-devel mailing list
ibm-acpi-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel

[Index of Archives]     [Linux ACPI]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Photo]     [Yosemite Photos]     [Yosemite Advice]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]

  Powered by Linux