Re: [PATCH 3/4] ACPI: thinkpad-acpi: disable backlight handler if ACPI generic could do it

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2007-10-09 at 10:43 +0200, Christian Birchinger wrote:
> On Tue, Oct 09, 2007 at 08:59:14AM +0100, Matthew Garrett wrote:
> > On Tue, Oct 09, 2007 at 08:21:14AM +0200, Thomas Renninger wrote:
> > 
> > > IMO a config variable that compiles out brightness control totally makes
> > > more sense (and video, is there any functionality in ThinkPad acpi
> > > driver that does not get supported by the video driver?).
> > 
> > No, older Thinkpads don't implement the video extension. It needs to be 
> > handled at runtime.
> 
> The ACPI video module acts a bit funny on my R61 (nvidia) anyway.
Then please file a bug report.

>  ~ $ ls /proc/acpi/video/
> VID/  VID/
> (Twice the same entry)
> 
> $ cat /proc/acpi/video/VID/LCD0/brightness
> levels:  100 100 20 25 30 35 40 45 50 55 60 65 70 75 80 85 90 100
> current: 0
> 
> While this works perfectly (read and control):
> $ cat /proc/acpi/ibm/brightness 
> level:          14
> commands:       up, down
> commands:       level <level> (<level> is 0-15)
> 
> So i'd prefer to have the thinkpad specific control available
> even if theres generic acpi/video.
It simply makes no sense to have two half way working interfaces.
We need one tested interface working reliable and that is, at least for
all recent models supporting Vista, the video driver implementation.

   Thomas


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
ibm-acpi-devel mailing list
ibm-acpi-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel

[Index of Archives]     [Linux ACPI]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Photo]     [Yosemite Photos]     [Yosemite Advice]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]

  Powered by Linux