Re: [ltp] Re: thinkpad-acpi release 0.17-20071002 uploaded to ibm-acpi.sf.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Henrique de Moraes Holschuh wrote:
> Here's the offending code, from backlight.c:
>
> [...]

Yes, I've read it pretty carefully.  That's what I marked up with
printk's to find the problem.  I agree with your analysis of the
fragility of the parsing, but that's not the problem I'm seeing.  (As I
think you're aware.)

What doesn't appear here is code to discard the input buffer when EINVAL
is returned.  I don't understand where that is supposed to happen, since
it would normally be handled by returning the number of characters read
from the buffer.  By returning EINVAL, there's no way to tell the caller
how many characters to discard from the buffer.  Am I missing something
here?

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
ibm-acpi-devel mailing list
ibm-acpi-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel

[Index of Archives]     [Linux ACPI]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Photo]     [Yosemite Photos]     [Yosemite Advice]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]

  Powered by Linux