Re: thinkpad-acpi release 0.16-20070922 uploaded to ibm-acpi.sf.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 23 Sep 2007, Michael Olbrich wrote:
> v2.6.23-rc7+thinkpad-acpi-20070922 does not compile so I used
> v2.6.22.7+thinkpad-acpi-20070922 instead:

Yeah, I noticed.  It is fixed in the git tree, I will push a new release
tomorrow.

> Just in tim then, right? This is a Z61m btw. with the latest BIOS.

I'd still like to get reports from older thinkpads (this patch is for them,
anyway :p)... and from a X61 or T61, as these have weirdness in their BIOSes
that the T60 and Z* don't have.

> I get new events for the thinklight and the mixer (up/down/mute).

Yeah, you can get them without the nvram too, but they default to being
masked out, and the "debug command" I gave you to enable NVRAM polling
enables it for every NVRAM-able hotkey, including thinklight and mixer.

> Howerver the brightness up/down keys are messed up. Without NVRAM
> polling I get events for every key press. With NVRAM polling I only get
> events when the brightness is actually changing (e.g. no event for "up"
> when the brightness is already at the maximum) and events get lost when
> I'm too fast.

Please increase hotkey_poll_freq, and tell me at which point it stops losing
events.  It defaults to 4Hz, which apparently is too low.  10Hz should do it
(it is what thinkpad-keys use), but if we can take it lower...

I will change the code to send brightness events on the extremes, too.
Volume needs that change as well.

> I get acpi and input events for all hotkeys is that the correct
> behaviour?

Yes.  The driver reports the keys in hotkey_mask & hotkey_source_mask.

> After pressing the sleep key (Fn-F4) and receiving the event I need to
> wait some time (>1min I think) before it works again. The same for
> suspend (Fn-F12). This problem also existed in version 0.15-20070723.

This is the firmware's doing, so I'd say it is the expected behaviour.

Thank you very much for the report!

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
ibm-acpi-devel mailing list
ibm-acpi-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel

[Index of Archives]     [Linux ACPI]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Photo]     [Yosemite Photos]     [Yosemite Advice]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]

  Powered by Linux