On Mon, 23 Jul 2007, Thomas Renninger wrote: > I wonder whether more/all thinkpad_acpi_module_exit() calls should get > reverted in thinkpad_acpi_module_init and cleanup should be done in the > init function itself. Maybe things get clearer then (not sure...). I will look into it. I didn't check or test your patch, but I will soon, so this is not an ACK yet. > Also the thinkpad module got loaded on a (non-lenovo :) ) server. Please send me the dmidecode output of the box which tried to auto-load thinkpad-acpi erroneously (feel free to clobber over any UUIDs and serial numbers, of course). > It could be that something explicitly tried loading it, but it Most distros try to load everything in their ACPI directory, but moving the driver to misc should have worked around that issue. > shouldn't. Possibly thinkpad-acpi gets loaded on a wider range of > systems due to the dmi udev change? Hmm, if yes, we should notice that > soon :). It should not have happened, no server should have a thinkpad dmi string, and the BIOS IDs I used are supposed to be unique. The dmidecode output from the server will tell me where it failed. > If thinkpad module tries to get loaded on a non-thinkpad machine you see: > WARNING: at lib/kref.c:33 kref_get() > > Call Trace: > [<ffffffff802fa57d>] kref_get+0x2f/0x36 > [<ffffffff802f97f7>] kobject_get+0x12/0x17 > [<ffffffff8036dfd7>] get_driver+0x14/0x1a > [<ffffffff8036dfee>] driver_remove_file+0x11/0x32 > [<ffffffff8823b9be>] :thinkpad_acpi:thinkpad_acpi_module_exit+0xa8/0xfc > [<ffffffff8824b8a0>] :thinkpad_acpi:thinkpad_acpi_module_init+0x74a/0x776 > [<ffffffff8024f968>] __link_module+0x0/0x25 > [<ffffffff80252269>] sys_init_module+0x162c/0x178f > [<ffffffff8020bc2e>] system_call+0x7e/0x83 Yeah, ugly. I will either take your patch, or fix it in some other way. -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ ibm-acpi-devel mailing list ibm-acpi-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
