Re: light toggle patch

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 08 Jul 2007, jieryn@xxxxxxxxx wrote:
> Thanks for working on this project, I appreciate it. :-) I have come
> across a rather small usability enhancement which I think others might
> find valuable.. please find an attached patch which allows the user to
> not only 'on', 'off' the thinklight, but also quickly 'toggle' it
> whatever the current status may be.

NAK (I can't accept the patch) because it extends the procfs interface, and
the rules for that are: bugfixes only.

Although, since the feature is useful to you, I have nothing against adding
something to sysfs that causes the toggling to happen.  It is probably
something the LED class supports properly, too anyway, but even if it
doesn't, I will try to fit toggling in.

I have added it to my TODO.

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
ibm-acpi-devel mailing list
ibm-acpi-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel

[Index of Archives]     [Linux ACPI]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Photo]     [Yosemite Photos]     [Yosemite Advice]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]

  Powered by Linux