Re: [PATCH] udev: sync udev rules directories with systemd units directories

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jul 13, 2012 at 11:21 PM, William Hubbs <w.d.hubbs@xxxxxxxxx> wrote:
> From: Michał Górny <mgorny@xxxxxxxxxx>
>
> This adds /usr/lib, /usr/local/lib, and /lib (if split-usr is enabled)
> to the directories where udev searches for rules.d. This brings udev in
> line with how systemd searches for units and it is also needed if
> split-usr is enabled because other software packages currently install
> rules in /lib/udev/rules.d.
> ---
>  src/udev/udev-rules.c |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/src/udev/udev-rules.c b/src/udev/udev-rules.c
> index b5b54dd..784d25e 100644
> --- a/src/udev/udev-rules.c
> +++ b/src/udev/udev-rules.c
> @@ -1759,7 +1759,12 @@ struct udev_rules *udev_rules_new(struct udev *udev, int resolve_names)
>
>          rules->dirs = strv_new(TEST_PREFIX SYSCONFDIR "/udev/rules.d",
>                                 TEST_PREFIX "/run/udev/rules.d",
> +                               TEST_PREFIX "/usr/local/lib/udev/rules.d",

Udev will *never* look in /usr/local, that is no place for
system-level software. My take on this is: early boot has absolutely
zero business in /usr/local.

I see that you just want to sync this, but I will not allow /usr/local
happen to udev. It makes no sense, does not solve any problem, creates
nothing but needless issues with custom setups and custom mounts
(which are not uncommon) on /usr/local that are better avoided.

I tried several times to talk Lennart out of that nonsense, but wasn't
successful so far. :)

>                                 TEST_PREFIX UDEVLIBEXECDIR "/rules.d",
> +                               TEST_PREFIX "/usr/lib/udev/rules.d",
> +#ifdef HAVE_SPLIT_USR
> +                               TEST_PREFIX "/lib/udev/rules.d",
> +#endif

I have no problem with that, even when I think it's the wrong way to
do these things. It just creates mess, that is much bigger than the
split-usr ever was. But we have it in systemd, and there is no real
argument for me to make against it.

Thanks,
Kay
--
To unsubscribe from this list: send the line "unsubscribe linux-hotplug" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel]     [Linux DVB]     [Asterisk Internet PBX]     [DCCP]     [Netdev]     [X.org]     [Util Linux NG]     [Fedora Women]     [ALSA Devel]     [Linux USB]

  Powered by Linux