On Tue, Apr 3, 2012 at 10:04, Nils Carlson <nils.carlson@xxxxxxxxxxxx> wrote: > This patch reintroduces enumeration > of the form > > pci-0000:05:00.0-sas-phy0-0x500000e114de2b42:0-lun0 > > where phy0 is the reintroduced substring where 0 corresponds > to the lowest phy identifier on the port to which the device > is connected. Without having any real insight knowledge, a quick check: We usually refuse any "find the lowest number approach" in new code, and require the kernel to export a stable instance number per parent device, which is entirely disconnected from any global device enumeration counter or prober ordering. Almost all existing examples doing that are broken, and some even needed to be removed because they just blindly bet on luck that things are always in the same probe order. Many device can individually unbound and rebound in the kernel, so after the rebind the same device will no longer have a smaller number like it had before. Kernel enumeration is only in a very few cases useful to build persistent paths. The approach in this case is safe against individual pieces being unregistered and registered again? Kay -- To unsubscribe from this list: send the line "unsubscribe linux-hotplug" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
