Hi Nils, Thanks a lot for this. It definitely a step in the correct direction. However, I have some comments to make: On 04/02/2012 02:56 PM, Nils Carlson wrote: > When path_id was converted to C code the enumeration of SAS > devices by phy disappeared. This patch reintroduces enumeration > of the form > > pci-0000:05:00.0-sas-phy0:1-0x500000e114de2b42:0-lun0 > > where phy0:1 is the reintroduced substring where 0 corresponds > to the lowest phy identifier on the port to which the device > is connected and 1 is the number of phys on the port. > I would rather not do this. First of all, I doubt we need the overall number of phys here. Secondly, James B. assured me that the phy enumeration is pretty much stable, so we should be able to use that number as-is. Also, there is a 1:1 match between the 'phy_identifier' sysfs attribute and the second number of the phy name itself (the first number is the SCSI host number), so we could as well just parse the phy name and get the number from there. But, of course, reading the phy_identifier is okay, too. So I would propose just to insert a 'phy1' there. But again, thanks for doing it. Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@xxxxxxx +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-hotplug" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
