On Wed, Mar 7, 2012 at 11:49, Andrew Vagin <avagin@xxxxxxxxxx> wrote: > The queue handling in the udev daemon assumes that the events are > ordered. > > Before this patch uevent_seqnum is incremented under sequence_lock, > than an event is send uner uevent_sock_mutex. I want to say that code > contained a window between incrementing seqnum and sending an event. > > This patch locks uevent_sock_mutex before incrementing uevent_seqnum. > > v2: delete sequence_lock, uevent_seqnum is protected by uevent_sock_mutex > v3: unlock the mutex before the goto exit > > Thanks for Kay for the comments. > > Signed-off-by: Andrew Vagin <avagin@xxxxxxxxxx> Looks good to me. Works fine in a kvm installation here. Feel free to add: Tested-By: Kay Sievers <kay.sievers@xxxxxxxx> Thanks lot for the udev debugging and taking care of it, Kay -- To unsubscribe from this list: send the line "unsubscribe linux-hotplug" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html