On Wed, Jun 15, 2011 at 09:13, Tejun Heo <htejun@xxxxxxxxx> wrote:
> Looks good to me. ÂJust some nitpicks.
>
> On Tue, Jun 14, 2011 at 10:24:16PM +0200, Kay Sievers wrote:
>> - Â Â if (last_present != cd->media_present)
>> + Â Â if (last_present != cd->media_present) {
>> Â Â Â Â Â Â Â events |= DISK_EVENT_MEDIA_CHANGE;
>> + Â Â } else if (events & DISK_EVENT_MEDIA_CHANGE) {
>> + Â Â Â Â Â Â cd->tur_mismatch++;
>> + Â Â Â Â Â Â printk("sr: GET_EVENT_STATUS_NOTIFICATION but TUR unchanged, "
>> + Â Â Â Â Â Â Â Â Â Â"last_present %i <-> cd->media_present %i, count %i\n", last_present, cd->media_present, cd->tur_mismatch);
>
> I suppose the above printk is for debugging and will be removed when
> posting for inclusion?
>
>> + Â Â Â Â Â Â if (cd->tur_mismatch > 8) {
>> + Â Â Â Â Â Â Â Â Â Â printk("sr: GET_EVENT_STATUS_NOTIFICATION but TUR unchanged, "
>> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â"ignoring all future GET_EVENT_STATUS_NOTIFICATION\n");
>> + Â Â Â Â Â Â Â Â Â Â cd->ignore_get_event = true;
>
> sdev_printk(KERN_WARNING, ...) would probably be a better fit.
>
>> + Â Â Â Â Â Â }
>> + Â Â } else if (cd->tur_mismatch) {
>> + Â Â Â Â Â Â printk("sr: GET_EVENT_STATUS_NOTIFICATION == TUR, "
>> + Â Â Â Â Â Â Â Â Â Â"clear mismatch count %i\n", cd->tur_mismatch);
>> + Â Â Â Â Â Â cd->tur_mismatch = 0;
>
> Ditto, we probably don't want the above in the final version.
Sure not, it's nothing to merge, I just wanted to see if we are on the
right track and how it behaves.
Any idea why with the first check GET_EVENT seems, but TUR seems to
indicate no change?
Kay
--
To unsubscribe from this list: send the line "unsubscribe linux-hotplug" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
