That happens though for CONFIG_XXXX, though usually the include file is further down in the #ifdef region. --jordan hargrave Dell Enterprise Linux Engineering -----Original Message----- From: Greg KH [mailto:greg@xxxxxxxxx] Sent: Monday, March 07, 2011 1:56 PM To: K, Narendra Cc: a.beregalov@xxxxxxxxx; linux-next@xxxxxxxxxxxxxxx; jbarnes@xxxxxxxxxxxxxxxx; linux-pci@xxxxxxxxxxxxxxx; linux-hotplug@xxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; mjg@xxxxxxxxxx; Domsch, Matt; Rose, Charles; Hargrave, Jordan; Iyer, Shyam; sfr@xxxxxxxxxxxxxxxx Subject: Re: [PATCH V4] Export ACPI _DSM provided firmware instance number and string name to sysfs On Mon, Mar 07, 2011 at 11:44:52AM -0800, Narendra_K@xxxxxxxx wrote: > --- a/drivers/pci/pci-label.c > +++ b/drivers/pci/pci-label.c > @@ -29,7 +29,9 @@ > #include <linux/nls.h> > #include <linux/acpi.h> > #include <linux/pci-acpi.h> > +#ifdef CONFIG_ACPI > #include <acpi/acpi_drivers.h> > +#endif You should never need a #ifdef in a .c file for an include file. If so, something is really wrong. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-hotplug" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
