can dependency on CONFIG_NET be dropped for /proc/sys/kernel/hotplug?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



  based on a discussion on another mailing list, it would appear that
this dependency in kernel/sysctl.c is overkill:

#if defined(CONFIG_HOTPLUG) && defined(CONFIG_NET)
        {
                .procname       = "hotplug",
                .data           = &uevent_helper,
                .maxlen         = UEVENT_HELPER_PATH_LEN,
                .mode           = 0644,
                .proc_handler   = proc_dostring,
        },
#endif

  as someone else explained, there is no need for that CONFIG_NET
dependency anymore, is there?  as i read it, you'll already have
hotplug support -- all the above gives you is the
/proc/sys/kernel/hotplug file that allows you to override the default
setting of /sbin/hotplug, yes?

  in the simple case, if it's feasible, one could just drop that
second dependency.  or if you wanted to make the proc file a truly
separate config choice, just invent a new Kconfig variable like, say,
HOTPLUG_PROC_FILE which depends on HOTPLUG.

  thoughts?

rday

p.s.  the poster on the other list referred to these links:

http://article.gmane.org/gmane.linux.kernel/363682
http://article.gmane.org/gmane.linux.kernel/402057

by way of explanation.

-- 

========================================================================
Robert P. J. Day                               Waterloo, Ontario, CANADA

            Linux Consulting, Training and Kernel Pedantry.

Web page:                                          http://crashcourse.ca
Twitter:                                       http://twitter.com/rpjday
========================================================================
--
To unsubscribe from this list: send the line "unsubscribe linux-hotplug" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel]     [Linux DVB]     [Asterisk Internet PBX]     [DCCP]     [Netdev]     [X.org]     [Util Linux NG]     [Fedora Women]     [ALSA Devel]     [Linux USB]

  Powered by Linux