On Wed, Jun 2, 2010 at 14:08, Robert P. J. Day <rpjday@xxxxxxxxxxxxxx> wrote:
> On Wed, 2 Jun 2010, Kay Sievers wrote:
>
>> Here comes a new udev version. Thanks to all who have contributed to
>> this release.
>
> i have one minor observation about the test utility. in
> udev-test.pl:
>
> if ($rules->{exp_add_error}) {
> print " as expected\n";
> } else {
> print "\n";
> system("tree $udev_root"); <-- this line
> print "\n";
> $error++;
> sleep(1);
> }
>
> obviously, if something goes wrong during the test, that script
> presumes that the "tree" utility is installed. on a stock ubuntu
> 10.04 system, it isn't so that system() call fails.
>
> is it worth verifying that "tree" is installed first before running
> the test?
Oh, it's like this since forever. I don't really care, because I can't
live without 'tree'. If you like, patch it to fall-back to 'find' or
'ls' or whatever makes sense, and I'll apply it. :)
Cheers,
Kay
--
To unsubscribe from this list: send the line "unsubscribe linux-hotplug" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
