On Fri, Apr 16, 2010 at 10:52:44PM +0400, Yury G. Kudryashov wrote:
> Dan Nicholson wrote:
>
> > On Fri, Apr 16, 2010 at 09:50:42AM +0400, Yury G. Kudryashov wrote:
> >> Hi!
> >>
> >> Review the attached patches, please.
> >
> >> From 5cc42c6f87f690fdf66e29de2a816dab49a119f4 Mon Sep 17 00:00:00 2001
> >> From: Yury G. Kudryashov <urkud.urkud@xxxxxxxxx>
> >> Date: Fri, 16 Apr 2010 00:21:02 +0400
> >> Subject: [PATCH 1/2] Include linux/types.h
> >
> > 1. Prefix the subject with "hid2hci: " so it's clear from the shortlog
> > what
> > this affects.
> >
> > 2. Please include some rational in the commit message. What prototype or
> > datatype is missing that requires including <linux/types.h>?
> Done.
> >> From f9881e554deafad1301d00e4539a02fe63078c00 Mon Sep 17 00:00:00 2001
> >> From: Yury G. Kudryashov <urkud.urkud@xxxxxxxxx>
> >> Date: Fri, 16 Apr 2010 09:38:32 +0400
> >> Subject: [PATCH 2/2] Add --with-firmware-path configure option
> >
> > Again, please include some rational in the commit message. What problem is
> > this solving?
> Done.
> >> @@ -97,6 +94,11 @@ int main(int argc, char **argv)
> >> unsigned int i;
> >> int rc = 0;
> >>
> >> + for (i = 0; i < ARRAY_SIZE(searchpath); i++) {
> >> + printf("Path %s\n", searchpath[i]);
> >> + }
> >> + return 0;
> >> +
> >
> > I'm pretty sure the program stops doing anything useful with this hunk. :)
> I really should stop posting patches after midnight. I hope that the
> attached version is better.
> From 6d2d2d4d2c665539c140bbf471c8d1e30baf508b Mon Sep 17 00:00:00 2001
> From: Yury G. Kudryashov <urkud.urkud@xxxxxxxxx>
> Date: Fri, 16 Apr 2010 00:21:02 +0400
> Subject: [PATCH 1/2] hid2hci: include linux/types.h for __u32
>
> __u32 in linux/hiddev.h is undefined on my laptop (linux-headers-2.6.28.5).
> Probably, this is a bug in kernel headers or in my distro but this would not hurt.
Looks good. I see you resent the other patch.
--
Dan
--
To unsubscribe from this list: send the line "unsubscribe linux-hotplug" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
