On Fri, Apr 16, 2010 at 10:51 AM, Yury G. Kudryashov <urkud@xxxxx> wrote: > Dan Nicholson wrote: > >>> @@ -156,7 +156,7 @@ EXTRA_DIST += \ >>> udev/udevd.xml >>> >>> %.7 %.8 : %.xml >>> - $(XSLTPROC) -o $@ -nonet >>> http://docbook.sourceforge.net/release/xsl/current/manpages/docbook.xsl >>> $< >>> + $(XSLTPROC) -o $@ >>> http://docbook.sourceforge.net/release/xsl/current/manpages/docbook.xsl >>> $< >> >> This is an unrelated change. Please remove it from this patch. > Oops. Sorry. I should've reread the patch before sending. >>> + [ >>> + OLD_IFS=$IFS >>> + IFS=: >>> + for i in $with_firmware_path >>> + do >>> + if [ "x${FIRMWARE_PATH}" == "x" ]; then >>> + FIRMWARE_PATH="\\\"${i}/\\\"" >>> + else >>> + FIRMWARE_PATH="${FIRMWARE_PATH}, \\\"${i}/\\\"" >>> + fi >>> + done >>> + IFS=$OLD_IFS >>> + ] >> >> I'm not sure what wrapping this whole section in [] quoting does. It looks >> like a good handling of the option, though. > It escapes "if [ ... ]". Ah. You can also use 'test "x$FIRMWARE_PATH" = x' to avoid that. Also, I should mention that you should use '=' instead of '==' since the former is portable across shells. -- Dan -- To unsubscribe from this list: send the line "unsubscribe linux-hotplug" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
