On Fri, Apr 16, 2010 at 03:03, Mike Brudevold <mike@xxxxxxxxxxxxx> wrote: > On Thu, Apr 15, 2010 at 1:15 PM, Kay Sievers <kay.sievers@xxxxxxxx> wrote: >> We retrieve a list of features, and only feature 0 is the list of >> profiles. I reworked the logic to use two loops to iterate over the >> lists, and use the variable length field of the "profiles" feature to >> find the correct number of profiles. Hope that fixes the problem you >> are seeing. > > Looks good and much cleaner. One thing though, the feature_profiles > function is missing profiles 0x8, 0x9, and 0xA. I have attached a > patch that fixes that. Otherwise the variable "cd_cd_rom" never gets > set! I guess this dead variable was never really interesting, because there seem to be no drives which can not read original old CDROMs, if they can read one of the newer formats. The other, more interesting stuff we got directly from the kernel ioctl. The debug output now looks nicer though. :) Applied. Thanks, Kay -- To unsubscribe from this list: send the line "unsubscribe linux-hotplug" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
