Re: ACL_MANAGE meaning in udev is inconsistent

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Le 04/03/2010 01:33, Kay Sievers a écrit :
2010/3/3 Martin Pitt<martin.pitt@xxxxxxxxxx>:
Rafał Rzepecki [2010-02-19  7:37 +0100]:
In extras/udev-acl/70-acl.rules:4 ACL_MANAGE is tested for zeroness to check
whether a device should be excluded from ACL management:

ENV{ACL_MANAGE}=="0", GOTO="acl_end"

This is not consistent with usage in extras/udev-acl/udev-acl.c:292:

Thanks for catching this! Fixed in

  http://git.kernel.org/?p=linux/hotplug/udev.git;a=commitdiff;h=5c3ebbf35a2c101e0212c7066f0d65e457fcf40c

I'll remove that later on. Please do not rely on this functionality.
The ACL_MANAGE key must not leak to any other rules file. We will
likely change that name to be able to speed things up, and nothing
should use it outside the acl rules file.

Hmm, this is problematic : a lot of rules outside udev are using ACL_MANAGE to specify ACL should be set for some devices. I would suggest to not "deprecate" ACL_MANAGE outside 70-acl.rules but internally to 70-acl.rules, use another variable.

--
Frederic Crozat
Mandriva
--
To unsubscribe from this list: send the line "unsubscribe linux-hotplug" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel]     [Linux DVB]     [Asterisk Internet PBX]     [DCCP]     [Netdev]     [X.org]     [Util Linux NG]     [Fedora Women]     [ALSA Devel]     [Linux USB]

  Powered by Linux