Re: [PATCH] race between util_create_path() and util_delete_path()?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

> >> I'm still concerned/interested about the effect on performance. But
> >
> > I guess that somebody should try it out ;-)
> 
> I'm pretty sure we should not introduce any sort of global
> serialization locks here. We have to handle thousands events in
> parallel on some boxes, and most of them don't need any of theses
> locks.
> 
> Why can't we just create the subdir and the link or node inside one
> and the same retry-loop? The link or node will pin the subdir and any

that certainly is _possible_ - it just seems to be pretty difficult
to do, at least for me. The syscall for creating the object is not
necessarily the immediate next thing after the call to
util_create_path(), ...

> competing remove will fail after that. We might in theory loop a while
> until we successfully create the dir and the node or link, but in real
> world setups it seems it just does not happen. That way we don't put
> possibly expensive stuff in the common code path.

... which, of course, possibly is exactly the problem in that regard,
too.

Florian
--
To unsubscribe from this list: send the line "unsubscribe linux-hotplug" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel]     [Linux DVB]     [Asterisk Internet PBX]     [DCCP]     [Netdev]     [X.org]     [Util Linux NG]     [Fedora Women]     [ALSA Devel]     [Linux USB]

  Powered by Linux